Fix issue which unsubscribed additional channels #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue that has been caused by the race of conditions on tab close and led to `presence leave` for channels that were still in use. refactor(shared-worker): change leeway for rapid heartbeat filter out Make leeway depending from the minimal heartbeat interval (5% from it) to filter out too rapid heartbeat calls.
parfeon
added
status: done
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
reviewed
Jun 18, 2025
mohitpubnub
approved these changes
Jun 18, 2025
Contributor
|
Great to see that codacy is fine and doesn't raise concern that additional calculation has added complexity in the code. |
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(shared-worker): fix issue which unsubscribed additional channels
Fix issue that has been caused by the race of conditions on tab close and led to
presence leavefor channels that were still in use.refactor(shared-worker): change leeway for rapid heartbeat filter out
Make leeway depending from the minimal heartbeat interval (5% from it) to filter out too rapid heartbeat calls.