Skip to content

Conversation

@deleonio
Copy link
Contributor

@deleonio deleonio commented Oct 2, 2025

Summary

  • render the shared collapsible helper with
    / markup and icon/label slots
  • update kol-accordion and kol-details to use the new summary ref, focus handling, and BEM classes
  • adjust styles, snapshots, and e2e tests for the new semantic structure

Testing

  • pnpm --filter @public-ui/components test:unit

https://chatgpt.com/codex/tasks/task_e_68dd922d4280832ba03b2474afe54f0f

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

&__wrapper {
/* Forces the element into its own GPU compositing layer (via 3D transform). Helps prevent rendering/layout bugs (e.g. #7511) and may improve animation performance. */
transform: translateZ(0);
display: grid;
/**
* The `overflow: hidden` ensures that the content is not visible during the animated
* opening and closing. This should also cut off overlays containing content, but it
*does not.
*/
overflow: hidden;
grid-template-rows: 0fr;
transition: grid-template-rows 0.3s;
}

P1 Badge Preserve grid layout when using <details>

After switching the collapsible container from a div to a <details> element, the user-agent now applies details:not([open]) > :not(summary) and details[open] > :not(summary) rules that set display: none/block with higher specificity than the .collapsible__wrapper { display: grid; … } declaration. This causes the wrapper to always render as display: block, so the grid-template-rows transition never runs and the accordion/details content opens and closes abruptly with no animation. Overriding the UA rule with a more specific selector (e.g. details.collapsible > .collapsible__wrapper) or !important is required to keep the grid-based animation working.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@deleonio deleonio marked this pull request as draft October 2, 2025 05:55
…ibility and structure

- Enhanced accordion and details components to use semantic HTML elements like <details> and <summary>.
- Updated test cases to reflect changes in button roles and labels for better accessibility.
- Refactored styles for consistency and improved layout.
- Adjusted event handling to ensure proper functionality when components are enabled or disabled.
@deleonio deleonio force-pushed the feature/implement-accordion-using-details-tag branch from 6ff7215 to c99821c Compare October 4, 2025 02:14
@deleonio deleonio changed the base branch from develop to release/3 October 11, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants