-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/license #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/license #310
Conversation
Walkthroughabout-libraries を導入し、WebView ベースのライセンス表示を LibrariesContainer ベースに置換。バージョンカタログ、モジュール依存、UI 実装、静的ライセンス資産、スクリーンショットテスト報告が併せて更新された。 Changes
Sequence Diagram(s)sequenceDiagram
participant Screen as LicenseScreen
participant Producer as produceLibraries()
participant AboutLib as LibrariesContainer
participant UI as AppScaffold/Snackbar
Screen->>Producer: 起動時にライブラリ情報生成要求
Producer-->>Screen: Libs データを返す
Screen->>AboutLib: LibrariesContainer(libraries=Libs)
AboutLib->>UI: ユーザ操作(詳細表示 / ダイアログ)
UI-->>AboutLib: ユーザ操作の結果(閉じる等)
AboutLib-->>Screen: 戻る操作時に onBack コール
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@AndroidApp/gradle/libs.versions.toml`:
- Line 36: Update the about-libraries dependency from the beta version to the
stable release by changing the toml entry about-libraries = "14.0.0-b01" to
about-libraries = "13.1.0" so the project uses the recommended stable 13.1.0
release instead of the beta.
| com-google-code-gson = "2.13.2" | ||
| com-squareup-leakcanary = "2.14" | ||
| mockk = "1.14.7" | ||
| about-libraries = "14.0.0-b01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
aboutlibraries mikepenz latest stable version 14.0.0
💡 Result:
Short answer: No — 14.0.0 is not a stable release yet. The latest stable release of AboutLibraries is 13.1.0; 14.0.0 artifacts are published as pre-releases (14.0.0-a*/b*). [1][2][3]
Sources:
- com.mikepenz artifact listing (shows aboutlibraries latest = 13.1.0). [1]
- Maven / mvnrepository entry for aboutlibraries-core 13.1.0 (stable, Oct 13, 2025). [2]
- Gradle Plugin Portal showing 14.0.0 pre-release versions (a01 / b01). [3]
References:
[1] (javadoc.io)
[2] (mvnrepository.com)
[3] (plugins.gradle.org)
Citations:
- 1: https://www.javadoc.io/doc/com.mikepenz?utm_source=openai
- 2: https://mvnrepository.com/artifact/com.mikepenz/aboutlibraries-core/13.1.0?utm_source=openai
- 3: https://plugins.gradle.org/plugin/com.mikepenz.aboutlibraries.plugin.android?utm_source=openai
about-libraries を安定版にアップグレードしてください。
現在使用している 14.0.0-b01 はベータ版です。最新の安定版は 13.1.0 (2025年10月13日リリース)です。本番環境では安定版を使用してください。バージョンを 13.1.0 に更新することをお勧めします。
🤖 Prompt for AI Agents
In `@AndroidApp/gradle/libs.versions.toml` at line 36, Update the about-libraries
dependency from the beta version to the stable release by changing the toml
entry about-libraries = "14.0.0-b01" to about-libraries = "13.1.0" so the
project uses the recommended stable 13.1.0 release instead of the beta.
Summary by CodeRabbit
改善
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.