[SYSINFO] Fixed readFreq for LoongArch64#3906
Merged
Merged
Conversation
We cannot use the "real" value from sysinfo because RDTSC opcode uses a "fake" rdtime.d.
Owner
|
What do you mean by "fake"? To me, it looks like the frequency of the internal timer was not read correctly, and can be different from the main cpu frequency after all. |
Collaborator
Author
|
Because it's not the freq, it's just a timer. |
Collaborator
Author
|
We can also turn the timer to real freq by multiplying something, but I'm not really motivated to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use the "real" value from sysinfo because RDTSC opcode uses a "fake" rdtime.d.