Fix incrementing before mmap success check#3515
Closed
devarajabc wants to merge 0 commit intoptitSeb:mainfrom
Closed
Fix incrementing before mmap success check#3515devarajabc wants to merge 0 commit intoptitSeb:mainfrom
devarajabc wants to merge 0 commit intoptitSeb:mainfrom
Conversation
Owner
|
I understand the issue, but this was done that way to help with mutli-threaded access and avoid having competition when initializing the new list. Not sure this fix will handle heavy multi-threading well. |
Owner
|
It would be safer to do the |
Contributor
Author
|
I see, you are right. The mmap failure path is nearly impossible to hit in practice. It's not worth it |
Contributor
Author
|
Maybe I can add a comment for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move list->size increment after the mmap failure check.
After mmap fails and returns 0, list->size has already been permanently incremented.
On the next call to AllocDynarecMap, this loop iterates up to the new list->size,
hitting the uninitialized list->chunks[i].