updates to facilitate openggcm xdmf data reading #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and clean up unused compiled code/test
instead of "time", which we don't have in the file, and also skip the run name, since we don't have that, either.
It's kinda fake in that the second timestep contains references to the very same data from the 1st step.
That puts it in line with other backends, though it isn't actually honoring them (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't change existing behavior for PSC xdmf data, but allow for reading of openggcm xdmf data. Also, it
now supports reading a overarching
xyz.xdmffile and add an additional time dimension.