Skip to content

Don't drop gauss/continuity variables #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesMcClung merged 3 commits into from
Nov 24, 2025
Merged

Don't drop gauss/continuity variables #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdd695e
psc: don't drop vars when they're also components
JamesMcClung Nov 24, 2025
eeac670
postprocessing: fix a spontaneously-generated mypy error
JamesMcClung Nov 24, 2025
cf6211c
postprocessing: fix the fix
JamesMcClung Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pscpy/postprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_recentered(
elif boundary == "zero":
shifted[{dim: boundary_idx}] = 0

return 0.5 * (da + shifted)
return 0.5 * (da + shifted) # type: ignore[no-any-return]


def _rename_var(ds: xr.Dataset, old_name: str, new_name: str) -> None:
Expand Down
8 changes: 4 additions & 4 deletions src/pscpy/psc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ def decode_psc(
ds = ds.squeeze("step")

for var_name in ds:
for component_idx, component in enumerate(
iter_components(var_name, species_names)
):
components = list(iter_components(var_name, species_names))
for component_idx, component in enumerate(components):
ds = ds.assign({component: ds[var_name][component_idx, :, :, :]})
ds = ds.drop_vars([var_name])
if var_name not in components:
ds = ds.drop_vars([var_name])

run_info = RunInfo(ds, length=length, corner=corner)
coords = {
Expand Down