Alternative method to iterating over field components #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this significantly affects performance one way or another
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Collaborator
Author
|
The failing code coverage is a symptom of a lack of sample data for tests. The fact that this fails is a point in the PR's favor, actually. If I had done #26 after this PR, it would have failed because the code coverage bot would have seen that the 1-line diff wasn't actually being tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't necessary for anything at all, it's essentially an aesthetic refactor of the
field_to_componentlogic. I (currently) prefer it, but it's no big deal to reject this PR.