-
Notifications
You must be signed in to change notification settings - Fork 16
Particle injector for boundary inflow #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle injector for boundary inflow #363
Conversation
|
I'm now thinking |
germasch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- I did go through it commit by commit (and, as usual, nice job breaking it up). Still couldn't say that I followed 100% of it, but I only have two minor concerns:
- The .999 to keep it away from the right boundary. I hit similar issues before in the particle boundary -- I think I used (1 - 1e-6) at that point. I guess neither is likely to cause any noticeable issues, though.
- You templated some injected particle generator class by the number of particles -- I don't think I saw why that's a template arg rather than just a regular argument.
|
What kind of issue, noticeable or not, would you anticipate from the .999? It does have to be in that cell, so 1.0 doesn't work. As for the templated count... yeah, that was just me doing the first thing that came to mind. I already have a note to fix that in the next PR I'll submit. |
the functionality of `Inflow` will be superseded by `InjectorBoundaryInflow`, which will be tested in test_injector_boundary_inflow
redoing inflow
so it "works" in debug mode
edfec0b to
cfd512c
Compare
Adds
InjectorBoundaryInflow, an injector (to be passed as theinject_particlesargument ofmakePscIntegrator) that injects particles at a boundary as if from a population of particles just beyond the edge. The injector has the following features:The injector currently has a few limitations, however:
Also note that the injector is not responsible for removing particles that exit the domain. This injector should be paired with a boundary condition of
BND_PRT_OPENthat removes exiting particles, although this functionality does not currently exist.See
test_injector_boundary_inflowfor example uses.