Skip to content

Conversation

@ravivlb
Copy link

@ravivlb ravivlb commented Feb 20, 2018

I have added the width and height to customise based on user

@prscX
Copy link
Owner

prscX commented Feb 20, 2018

Thanks @ravivlb for the PR.

Definitely it make sense to have a customise layer for the container size. Before merging PR I have couple of questions:

  • You have made changes in style but we are also passing size prop to native. Do we have to change their also? If yes then we can completely get rid of size prop and introduce width & height as default props.
  • Should we add width & height prop to class prop types as well and also provide some default value to the same?
  • Just by changing in style is it working as expected for you?

Thanks
Pranav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants