Cursor Corrected Unit Tests for New State of Health #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… health pre-repo organization to work with new repo structure)
… for boot count and flags
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into new-state-of-health
Co-authored-by: JamesDCowley <jcowley04@hotmail.com>
Signed-off-by: Michael Pham <61564344+Mikefly123@users.noreply.github.com>
Signed-off-by: Michael Pham <61564344+Mikefly123@users.noreply.github.com>
Signed-off-by: Michael Pham <61564344+Mikefly123@users.noreply.github.com>
Signed-off-by: Michael Pham <61564344+Mikefly123@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the StateOfHealth unit tests and updates the implementation to validate sensor readings against a configuration schema. Key changes include updated dependency mocks and configuration in the tests, new tests covering sensor error conditions, and enhancements to the StateOfHealth methods for checking sensor readings.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/test_state_of_health.py | Updated tests with new config schema, sensor mocks, and enhanced validation checks. |
| pysquared/state_of_health.py | Modified sensor checking logic to use _check_against_schema_bounds and improved method documentation. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
Closing since #235 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cursor was used in Agent Mode to address the
typecheckandtesterrors that were showing on the original #235 branch. Within the actual state of health file only some imports, type hints, and a return statement has changed. The tests have changed significantly, and I need to take a little more time to really understand the changes. I'll also try running this on hardware tomorrow (June 20th) to verify it works on the V5b.How was this tested