Revise dossier base schema structure#33
Open
dhh1128 wants to merge 1 commit into
Open
Conversation
Update the Dossier (Base) schema with a refined field set and clearer field semantics: - Add issuer/schema fields (i, s) and a top-level rules block (r) to the required ACDC envelope; reorder envelope fields. - Reframe the IS-A-dossier definition recursively via allOf $ref chains. - Expand a-block metadata descriptions; rename assemble_dt -> assembly_dt and class -> cls; allow object form for evt_loc; relax jur array minItems. - Drop the redundant a.dt field (issuance date lives on the envelope). - Restructure the e (edges) block description for compact/expanded forms. - Recompute $id SAID to ECqmlipYuqp8LA_7WdZGt_cKP9eK3hXtHRZGNgJ7NKEx. Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the dossier-base JSON Schema to replace the prior placeholder dossier definition with a more explicit ACDC envelope layout and clearer semantics for the metadata (a) and edges (e) blocks.
Changes:
- Revises the envelope to emphasize conventional field ordering and to include issuer (
i), schema (s), and an optional rules block (r). - Refines the
a(metadata) block semantics and field names (e.g.,assemble_dt→assembly_dt,class→cls) and relaxes some constraints. - Clarifies
e(edges) block semantics as supporting compact (SAID) and expanded (object) forms while deferring edge shapes to derived schemas.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
43
| "r": { | ||
| "description": "Optional ACDC rules block. Compact form: SAID string. Expanded form: object." | ||
| }, |
| "v": { | ||
| "type": "string", | ||
| "description": "ACDC version string." | ||
| "description": "CESR version string." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes an update to the Dossier (Base) schema (
dossier-base/dossier-base.json), replacing the placeholder base with a refined field set and clearer field semantics.Envelope
i) and schema (s) fields and a top-level rules block (r) to the ACDC envelope; reorder envelope fields for the conventionalv, d, i, s, ...ordering.Sis a dossier iff its top-levelallOfcontains a$refto this SAID, or recursively to another dossier schema. Issuee discouraged; all evidence carried ine, nevera.a(metadata) blockassemble_dt→assembly_dtandclass→cls.evt_loc; relaxjurarrayminItemsconstraint.a.dtfield — issuance date lives on the envelope.e(edges) blockSAID
$idrecomputed toECqmlipYuqp8LA_7WdZGt_cKP9eK3hXtHRZGNgJ7NKEx. Verified self-consistent against the schema content viakeri.core.scheming.Schemer(the same computation astools/cli/saidify_schema.py).🤖 Generated with Claude Code