You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 26, 2024. It is now read-only.
The version 2.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of cordova-plugin-ionic-webview.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
WebViewLocalServer.java: return 404 error code when a local file is not found (#217) (f7a551e), closes #216
BREAKING CHANGES
iOS: Sets deployment-target to 11, so will only work on iOS 11+
Address changes
changes the default from 1 (never) to 0 (always)
WebViewLocalServer.java: Until now, the Android part of the plugin was returning a 200 http code even though
the requested file didn't exist. This behavior was inconsistent with the historical behavior of the
iOS webView. This change makes them both work in the same manner but introduces a breaking change
for the current Android users that are expecting a 200 http code no matter what and are testing the
not found error just by checking if the body is null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2.0.0 of cordova-plugin-ionic-webview was just published.
The version 2.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of cordova-plugin-ionic-webview.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 66 commits.
2e94e852.0.0ef0e2b5docs(changelog): set date for 2.0.00b730cadocs: remove beta referencese952acdMerge pull request #125 from ghenry22/patch-381d679aMerge pull request #123 from ghenry22/patch-17eedf67remove unused allowremoteconnect value086bf44remove unused allowRemote variableddf8b312.0.0-beta.237331d4Fix setServerBasePath (#121)785c19fdocs(readme): fix duplication in readme7d863eadocs(readme): fix install command to use beta91b19c2fix(android): Make path final to avoid cordova 6.4.0 complaint (#120)570b1f7Merge pull request #117 from ghenry22/ios_background_mode123c51efix change item formatting4ed9b9findicate when background mode is enabled in xcode logThere are 66 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴