Refactor SourceLocationTest to use MatchesSubstring matcher.#26517
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 26, 2026
Merged
Refactor SourceLocationTest to use MatchesSubstring matcher.#26517copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_887875804
branch
from
b4a25af to
7325550
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_887875804
branch
from
7325550 to
b51ef20
Compare
It improves readability and debugabality of tests allowing engineers directly see expected matching substring instead of manually translating line/col into substring. PiperOrigin-RevId: 889606114
copybara-service
Bot
force-pushed
the
test_887875804
branch
from
b51ef20 to
1bd8604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SourceLocationTest to use MatchesSubstring matcher.
It improves readability and debugabality of tests allowing engineers directly see expected matching substring instead of manually translating line/col into substring.