Interrupt work of TextFormat::Printer on `io::ZeroCopyOutputStream:…

[kpavlov00]

…:Next` fail

[kpavlov00]

Relates: #23288

[kpavlov00]

Style nit: several new if (generator->Failed()) blocks use extra indentation versus the surrounding 2-space blocks in text_format.cc.

@themavik thank you, style fixed

[kpavlov00]

@esrauchg Hello, I just wonder is everything ok with this PR?
It is very important for our project
thanks

[esrauchg]

Sorry about the delay getting back to you.

I looked at the PR with @sbenzaquen and I think that the narrow shape of the change doesn't look like something like something we can accept as is (a number of invasive if's at arbitrary points, especially without test coverage).

And I'm not sure locally if it can easily be made super clean here.

Can you actually speak a bit more for the importance of the behavior for your business usecase, why is failed-printing something that you are hitting often enough to be a topic of concern for optimizing?

Thanks!

[kpavlov00]

@esrauchg Thank you for the answer

In most of our services, we use TextFormat::Printer::Print to log requests/responses,
and we passing io::ArrayOutputStream of limited size to it.

Since the capacity of Output is limited, we want to have a limited execution time.

However, the current implementation doesn't have the ability to interrupt its execution.

Small deviations can be considered non-critical,
but interrupting and not continuing to the end of the message if its size is significantly larger than the Output capacity becomes performance critical.