chore(deps): bump fast-csv 4 → 5 to clear deprecation#72
Open
senoff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Problem
fast-csvv4.x shows a deprecation notice onnpm installfor downstream consumers. Bumping to v5 clears the notice and brings in maintenance updates.Cause
fast-csv@4.3.1was pinned; v5.0.0 was released in 2023 and the v4 line is no longer maintained.Fix
Bumped
fast-csvfrom^4.3.1to^5.0.0inpackage.json. Rannpm install --legacy-peer-depsto updatepackage-lock.json(legacy-peer-deps required for the existing devDependency ESLint config tree).The only
fast-csvusage in this repo islib/csv/csv.js, which calls:fastCsv.parse(options.parserOptions)— stream pipeline; API unchanged in v5.fastCsv.format(options.formatterOptions)— stream pipeline; API unchanged in v5.Files changed
package.json—fast-csvversion stringpackage-lock.json— updated@fast-csv/format,@fast-csv/parseentries (v4.3.5 → v5.0.7)Test Run
Runtime smoke test (AGENTS.md Rule 7): wrote a 2-row workbook to CSV via
wb.csv.writeFile(), read it back viawb2.csv.readFile(), verified row values match. Passed.CSV integration test
spec/integration/issues/issue-991-csv-read-dates.spec.js: 1 passing.Cross-PR check
No other open senoff PR touches
package.jsonorpackage-lock.json. Unzipper bump is in a separate PR per AGENTS.md Rule 8.Excel/soffice verification
Not applicable — dep bump only, no XLSX serialization path touched.
grace-review summary
openai:gpt-5.5 — No defects found. gemini — CRITICAL: "major version bump without code adaptation." Dismissed: smoke test and CSV integration test both pass;
fast-csv.parse()andfast-csv.format()stream APIs are unchanged in v5. gemini's concern was generic, not informed by the actual API surface used in this codebase.Note: committed with
--no-verifyper AGENTS.md Rule 1.