Fix empty file generation for create-settings-file#349
Open
ppradyoth wants to merge 2 commits into
Open
Conversation
added 2 commits
May 25, 2026 17:40
Fixes protectai#327 When generating the default TOML settings file, the DEFAULT_SETTINGS dictionary mistakenly used Property objects as keys instead of strings. This caused tomlkit.dumps() to throw a TypeError under the hood, which was silently swallowed, resulting in an empty configuration file being written. Using the .value string representation fixes the serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when running
modelscan create-settings-file, the generated.tomlconfiguration file is totally empty instead of containing the default settings.The issue seems to be that in
DEFAULT_SETTINGS,Propertyobjects were used as dictionary keys underformatsinstead of strings. Whentomlkit.dumps()attempts to serialize it, it silently raises aTypeErrorand leaves the opened file empty.I appended
.valueto these enum members to ensure they are standard strings. Tested locally and the TOML generates perfectly now. Let me know if you prefer a different approach!Fixes #327