feat(banner): add pushDown option to push content down #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix layout with proper flexbox structure - Update to cleaner color scheme (white bg, better contrast) - Improve spacing and typography - Better dark mode support - More professional button styles - Responsive mobile layout improvements
Add optional pushDown config to banner plugin that allows top banners
to smoothly push page content down (add margin-top) instead of overlaying.
Usage:
init({
banner: {
position: 'top',
pushDown: 'header' // CSS selector
}
});
- Opt-in feature (default behavior unchanged)
- Smooth transition with CSS animations
- Automatically removes margin when dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
pushDownconfig to banner plugin that allows top banners to smoothly push page content down (add margin-top) instead of overlaying it.Changes
pushDown?: stringtoBannerPluginConfigapplyPushDown()andremovePushDown()helper functionsUsage
Benefits
Testing