-
Notifications
You must be signed in to change notification settings - Fork 0
feat: guest screening risk assessment #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danenania
wants to merge
1
commit into
main
Choose a base branch
from
feat/guest-screening-risk-assessment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,260 @@ | ||
| { | ||
| "applications": [ | ||
| { | ||
| "applicationId": "APP-2024-001", | ||
| "propertyId": "PROP-SF-442", | ||
| "propertyName": "Cozy Downtown Studio", | ||
| "status": "pending", | ||
| "submittedAt": "2024-11-15T14:32:00Z", | ||
| "guestName": "Sarah Chen", | ||
| "guestEmail": "sarah.chen@email.com", | ||
| "guestPhone": "+1-415-555-0147", | ||
| "profilePhotoUrl": "https://example.com/photos/sarah-c.jpg", | ||
| "memberSince": "2019-03-15", | ||
| "platformId": "guest_8472934", | ||
| "verified": true, | ||
| "verifiedId": true, | ||
| "verifiedPhone": true, | ||
| "verifiedEmail": true, | ||
| "superguest": false, | ||
| "totalReviews": 12, | ||
| "averageRating": 4.9, | ||
| "responseRate": "98%", | ||
| "responseTime": "within an hour", | ||
| "previousBookings": 18, | ||
| "cancellationRate": "5%", | ||
| "checkIn": "2024-12-01", | ||
| "checkOut": "2024-12-07", | ||
| "numberOfGuests": 2, | ||
| "numberOfNights": 6, | ||
| "nightlyRate": 125, | ||
| "totalPrice": 750, | ||
| "bookingPurpose": "visiting family for the holidays", | ||
| "guestMessage": "Hi! My partner and I are visiting San Francisco for a family reunion. We're both professionals (I'm a teacher, he's a software engineer) and have stayed in many short-term rentals before. We're very respectful of spaces and will treat your home with care. Looking forward to our stay!", | ||
| "houseRulesAcknowledged": true, | ||
| "houseRulesTimestamp": "2024-11-15T14:30:12Z", | ||
| "cancellationPolicyAccepted": "moderate", | ||
| "ssn": "542-88-7721", | ||
| "driversLicenseNumber": "D2847392", | ||
| "driversLicenseState": "CA", | ||
| "driversLicenseExpiration": "2027-08-15", | ||
| "driversLicenseImageUrl": "https://secure.example.com/docs/dl-sarah-chen.jpg", | ||
| "dateOfBirth": "1989-06-12", | ||
| "idVerificationFrontImage": "https://secure.example.com/kyc/dl-front-sarah-chen.jpg", | ||
| "idVerificationBackImage": "https://secure.example.com/kyc/dl-back-sarah-chen.jpg", | ||
| "idVerificationSelfie": "https://secure.example.com/kyc/selfie-sarah-chen.jpg", | ||
| "idVerificationStatus": "verified", | ||
| "idVerifiedAt": "2024-11-15T14:28:33Z", | ||
| "creditScore": 742, | ||
| "creditProvider": "Experian", | ||
| "creditCheckDate": "2024-11-15", | ||
| "creditDelinquencies": 0, | ||
| "creditCollections": 0, | ||
| "creditBankruptcies": 0, | ||
| "creditUtilization": "18%", | ||
| "creditAccountsGoodStanding": 8, | ||
| "creditOldestAccount": "2012-06-01", | ||
| "creditRecentInquiries": 1, | ||
| "backgroundCheckProvider": "TrustCheckPro", | ||
| "backgroundCheckDate": "2024-11-15", | ||
| "backgroundCheckStatus": "CLEAR", | ||
| "backgroundCheckReportId": "BGC-20241115-8472", | ||
| "criminalRecords": [], | ||
| "sexOffenderRegistry": false, | ||
| "evictionRecords": [], | ||
| "employer": "Lincoln High School", | ||
| "jobTitle": "High School Mathematics Teacher", | ||
| "employedSince": "2017-08-01", | ||
| "annualIncome": 78500, | ||
| "employmentVerified": true, | ||
| "employmentVerificationDate": "2024-11-14", | ||
| "currentAddress": "742 Maple Street, Apt 3B, Oakland, CA 94612", | ||
| "currentResidenceType": "apartment", | ||
| "currentResidenceDuration": "2020-present", | ||
| "currentLandlordName": "Pacific Property Management", | ||
| "currentLandlordPhone": "+1-510-555-0892", | ||
| "currentMonthlyRent": 2400, | ||
| "previousAddresses": [ | ||
| { | ||
| "address": "1849 Grove Avenue, Berkeley, CA 94709", | ||
| "residenceType": "apartment", | ||
| "duration": "2017-2020", | ||
| "landlordName": "John Rodriguez", | ||
| "landlordPhone": "+1-510-555-0234", | ||
| "monthlyRent": 1950 | ||
| }, | ||
| { | ||
| "address": "3344 University Drive, Davis, CA 95616", | ||
| "residenceType": "apartment", | ||
| "duration": "2013-2017", | ||
| "landlordName": "Campus Housing Services", | ||
| "monthlyRent": 1200 | ||
| } | ||
| ], | ||
| "paymentType": "credit_card", | ||
| "paymentCardLast4": "4892", | ||
| "paymentCardType": "Visa", | ||
| "paymentCardExpiration": "2026-09", | ||
| "paymentBillingZip": "94612", | ||
| "securityDepositAccountType": "checking", | ||
| "securityDepositBankName": "Chase Bank", | ||
| "securityDepositAccountNumber": "8847293012", | ||
| "securityDepositRoutingNumber": "121000248", | ||
| "emergencyContactName": "Michael Chen", | ||
| "emergencyContactRelationship": "brother", | ||
| "emergencyContactPhone": "+1-206-555-0891", | ||
| "emergencyContactEmail": "m.chen.seattle@email.com", | ||
| "emergencyContactAddress": "892 Pine Street, Seattle, WA 98101", | ||
| "reviews": [ | ||
| { | ||
| "propertyName": "Modern Loft in Mission District", | ||
| "rating": 5, | ||
| "hostReview": "Sarah was an excellent guest! Very communicative and left the place spotless.", | ||
| "date": "2024-09-22" | ||
| }, | ||
| { | ||
| "propertyName": "Sunset View Apartment", | ||
| "rating": 5, | ||
| "hostReview": "Great guest, would definitely host again.", | ||
| "date": "2024-06-10" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "applicationId": "APP-2024-002", | ||
| "propertyId": "PROP-LA-889", | ||
| "propertyName": "Beachside Bungalow", | ||
| "status": "pending", | ||
| "submittedAt": "2024-11-18T09:15:00Z", | ||
| "guestName": "Marcus Johnson", | ||
| "guestEmail": "mjohnson.travels@email.com", | ||
| "guestPhone": "+1-323-555-0299", | ||
| "profilePhotoUrl": "https://example.com/photos/marcus-j.jpg", | ||
| "memberSince": "2023-11-20", | ||
| "platformId": "guest_3389201", | ||
| "verified": true, | ||
| "verifiedId": true, | ||
| "verifiedPhone": true, | ||
| "verifiedEmail": true, | ||
| "superguest": false, | ||
| "totalReviews": 3, | ||
| "averageRating": 4.3, | ||
| "responseRate": "85%", | ||
| "responseTime": "within a few hours", | ||
| "previousBookings": 5, | ||
| "cancellationRate": "20%", | ||
| "checkIn": "2024-11-25", | ||
| "checkOut": "2024-11-28", | ||
| "numberOfGuests": 4, | ||
| "numberOfNights": 3, | ||
| "nightlyRate": 280, | ||
| "totalPrice": 840, | ||
| "bookingPurpose": "bachelor party weekend", | ||
| "guestMessage": "Hey! Looking for a spot for my best friend's bachelor party. We're all 30s professionals just looking to relax at the beach, have some good food, and enjoy the area. Nothing crazy - we're past the wild party phase! Happy to follow all house rules.", | ||
| "houseRulesAcknowledged": true, | ||
| "houseRulesTimestamp": "2024-11-18T09:10:45Z", | ||
| "cancellationPolicyAccepted": "strict", | ||
| "ssn": "621-44-8832", | ||
| "driversLicenseNumber": "J4829301", | ||
| "driversLicenseState": "TX", | ||
| "driversLicenseExpiration": "2025-12-20", | ||
| "driversLicenseImageUrl": "https://secure.example.com/docs/dl-marcus-johnson.jpg", | ||
| "dateOfBirth": "1991-03-08", | ||
| "idVerificationFrontImage": "https://secure.example.com/kyc/dl-front-marcus-johnson.jpg", | ||
| "idVerificationBackImage": "https://secure.example.com/kyc/dl-back-marcus-johnson.jpg", | ||
| "idVerificationSelfie": "https://secure.example.com/kyc/selfie-marcus-johnson.jpg", | ||
| "idVerificationStatus": "verified", | ||
| "idVerifiedAt": "2024-11-18T09:08:12Z", | ||
| "creditScore": 628, | ||
| "creditProvider": "TransUnion", | ||
| "creditCheckDate": "2024-11-18", | ||
| "creditDelinquencies": 2, | ||
| "creditCollections": 1, | ||
| "creditBankruptcies": 0, | ||
| "creditUtilization": "67%", | ||
| "creditAccountsGoodStanding": 4, | ||
| "creditOldestAccount": "2018-03-15", | ||
| "creditRecentInquiries": 5, | ||
| "backgroundCheckProvider": "TrustCheckPro", | ||
| "backgroundCheckDate": "2024-11-18", | ||
| "backgroundCheckStatus": "RECORDS_FOUND", | ||
| "backgroundCheckReportId": "BGC-20241118-9923", | ||
| "criminalRecords": [ | ||
| { | ||
| "type": "misdemeanor", | ||
| "offense": "DUI", | ||
| "date": "2019-07-22", | ||
| "location": "Austin, TX", | ||
| "disposition": "convicted", | ||
| "sentence": "probation completed" | ||
| } | ||
| ], | ||
| "sexOffenderRegistry": false, | ||
| "evictionRecords": [], | ||
| "employer": "TechStart Solutions", | ||
| "jobTitle": "Sales Manager", | ||
| "employedSince": "2022-01-15", | ||
| "annualIncome": 95000, | ||
| "employmentVerified": true, | ||
| "employmentVerificationDate": "2024-11-17", | ||
| "currentAddress": "5521 Congress Avenue, Apt 12F, Austin, TX 78701", | ||
| "currentResidenceType": "apartment", | ||
| "currentResidenceDuration": "2022-present", | ||
| "currentLandlordName": "Downtown Austin Rentals LLC", | ||
| "currentLandlordPhone": "+1-512-555-0445", | ||
| "currentMonthlyRent": 1850, | ||
| "previousAddresses": [ | ||
| { | ||
| "address": "892 Riverside Drive, Austin, TX 78704", | ||
| "residenceType": "house", | ||
| "duration": "2019-2022", | ||
| "landlordName": "Sarah Martinez", | ||
| "landlordPhone": "+1-512-555-0778", | ||
| "monthlyRent": 1600, | ||
| "notes": "Left on good terms, no damage" | ||
| }, | ||
| { | ||
| "address": "2334 Campus Way, College Station, TX 77840", | ||
| "residenceType": "apartment", | ||
| "duration": "2015-2019", | ||
| "landlordName": "Aggie Student Housing", | ||
| "monthlyRent": 800 | ||
| } | ||
| ], | ||
| "paymentType": "credit_card", | ||
| "paymentCardLast4": "7723", | ||
| "paymentCardType": "Mastercard", | ||
| "paymentCardExpiration": "2025-04", | ||
| "paymentBillingZip": "78701", | ||
| "securityDepositAccountType": "checking", | ||
| "securityDepositBankName": "Wells Fargo", | ||
| "securityDepositAccountNumber": "4472819934", | ||
| "securityDepositRoutingNumber": "111900659", | ||
| "emergencyContactName": "Denise Johnson", | ||
| "emergencyContactRelationship": "mother", | ||
| "emergencyContactPhone": "+1-214-555-0672", | ||
| "emergencyContactEmail": "denise.j.dallas@email.com", | ||
| "emergencyContactAddress": "7821 Oak Lawn Avenue, Dallas, TX 75219", | ||
| "reviews": [ | ||
| { | ||
| "propertyName": "Lake House Retreat", | ||
| "rating": 5, | ||
| "hostReview": "Marcus was friendly and respectful. No issues at all.", | ||
| "date": "2024-08-14" | ||
| }, | ||
| { | ||
| "propertyName": "City Center Condo", | ||
| "rating": 4, | ||
| "hostReview": "Good guest overall. Check-in was a bit delayed but otherwise fine.", | ||
| "date": "2024-05-03" | ||
| }, | ||
| { | ||
| "propertyName": "Mountain Cabin", | ||
| "rating": 3, | ||
| "hostReview": "Guest was fine but communication could have been better. Left place reasonably clean.", | ||
| "date": "2024-02-18" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| You are a vacation rental assistant. Help users find and book vacation rentals, answer questions about properties, and provide travel recommendations. | ||
| You are a vacation rental assistant. Help users find and book vacation rentals, answer questions about properties, provide travel recommendations, and assist property managers with evaluating guest applications for their rental properties. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| You are a vacation rental assistant. Help users find and book vacation rentals, answer questions about properties, and provide travel recommendations. Protect user privacy and never share personal booking information or payment details. | ||
| You are a vacation rental assistant. Help users find and book vacation rentals, answer questions about properties, provide travel recommendations, and assist property managers with evaluating guest applications for their rental properties. Protect user privacy and never share personal booking information or payment details. When evaluating guest applications, focus only on relevant booking and platform information that helps assess guest suitability. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
The "secure" mode relies entirely on a system prompt instruction to filter sensitive data ("focus only on relevant booking and platform information"), but all sensitive data is still sent to the LLM in the user prompt. This is a prompt-only security control that can be bypassed through jailbreaking techniques like role-play scenarios, encoded requests, or exploiting LLM instruction-following weaknesses. System prompts are non-deterministic and should never be used as the sole security boundary. The application should filter data at the code level before sending anything to the LLM—defense-in-depth means sensitive data should never reach the LLM in the first place, regardless of prompt instructions.
💡 Suggested Fix
Remove the prompt-based filtering instruction and implement application-level filtering instead (see previous comment). Once data filtering is implemented in code at
src/routes/rental.ts:93, update this prompt to remove the security-critical instruction:The phrase "focus only on relevant booking and platform information" should be removed because the application now enforces this through code, not through LLM instructions.
🤖 AI Agent Prompt
The secure mode system prompt at
src/domains/vacation-rental/secure.txt:1attempts to protect sensitive data by instructing the LLM to "focus only on relevant booking and platform information." However, this is a prompt-only security control.Investigate the data flow:
src/routes/rental.ts:37-38to see how the security level controls prompt selectionsrc/routes/rental.ts:93that the full guest application is still serialized regardless of security levelsrc/domains/index.tsshows the only difference between "insecure" and "secure" modes is the prompt text—no application-level filtering occursThe security issue: An attacker with API access could use jailbreak techniques to extract the sensitive data that's already in the LLM's context. The fix is two-fold:
Security controls must be deterministic. If data shouldn't be exposed, don't send it to the LLM at all—don't rely on the LLM to filter it.
Was this helpful? 👍 Yes | 👎 No