fix(skills): UUID resolution, ambiguity errors, delete command, short IDs#57
Merged
Merged
Conversation
… IDs Re-running 'skills generate' creates name duplicates by design (the platform doesn't dedup across detection runs). Before this change, the CLI silently picked the first match in any name lookup — install, uninstall, approve, reject — so you could end up with the wrong row. There was also no way to soft-delete a duplicate from the CLI. Changes: - Positional argument on install/uninstall/approve/reject/delete now accepts either a skill name or a UUID. UUIDs route through GET /v1/skills/:id directly; names use the list+filter path. - Ambiguous name lookups now error loudly with each candidate's UUID, repo scope, confidence, and approval state — actionable surface for picking the right row. - New 'promptconduit skills delete <name|uuid> [--yes]' calls DELETE /v1/skills/:id (soft-delete). Requires --yes on non-TTY. - 'skills list' now shows the first 8 chars of each skill's UUID as a prefix column, so users can copy a UUID into install/delete/etc. without dropping to --format json. - Resolved name shown in approve/reject output (friendlier than echoing a UUID back when the user passed one). API client additions: - Client.GetSkill(id) — GET /v1/skills/:id - Client.DeleteSkill(id) — DELETE /v1/skills/:id (soft) - Client.deleteRequest helper, paralleling patchRequest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the four CLI gaps that surfaced while installing one global skill:
Plus: API client gains `GetSkill(id)`, `DeleteSkill(id)`, and a `deleteRequest` helper paralleling `patchRequest`.
Why now
Repeated runs of `skills generate` create duplicate skills with the same name but different IDs (the platform doesn't dedup across detection runs). Before this change, the CLI silently picked the first match — could approve, install, or reject the wrong row without any signal. Caught it manually this week; would have caused real damage in scripted/CI use.
Behavior contract
Test plan
Out of scope (separate ticket)
Ships as v0.3.6 — additive, no breaking changes.