Handle asyncio.CancelledError in SSH session interaction#2072
Open
dnyanesh1011 wants to merge 3 commits into
Open
Handle asyncio.CancelledError in SSH session interaction#2072dnyanesh1011 wants to merge 3 commits into
dnyanesh1011 wants to merge 3 commits into
Conversation
|
|
||
| except asyncio.CancelledError: | ||
| # Expected during disconnect/shutdown. | ||
| pass |
Member
There was a problem hiding this comment.
Can you propagate rather than suppress using raise instead of pass?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes noisy traceback propagation during SSH session cancellation.
Currently
_interact()catchesBaseException, which also capturesasyncio.CancelledError. In modern asyncio versions (especially Python 3.11+ / 3.13),CancelledErroris expected control-flow during task shutdown and should not be treated as an application error.This change:
asyncio.CancelledErrorexplicitlyCtrl-Cduring the asyncssh example progress demoRelated issue: #1991