Skip to content

SPIFFE support#387

Open
kfox1111 wants to merge 5 commits into
prometheus:masterfrom
kfox1111:spiffe
Open

SPIFFE support#387
kfox1111 wants to merge 5 commits into
prometheus:masterfrom
kfox1111:spiffe

Conversation

@kfox1111
Copy link
Copy Markdown

@kfox1111 kfox1111 commented Mar 28, 2026

This feature allows the service to be MTLS secured automatically using SPIFFE/SPIRE.

tls_server_config:
  spiffe:
    enabled: true
    socket_path: "unix:///tmp/spire-agent/public/api.sock"

    # optional list of spiffeids to allow.
    # if not specified, spiffe://<trust_domain>/prometheus> will be validated
    #authorized_ids:
    # -  spiffe://example.org/prometheus1
    # -  spiffe://example.org/prometheus2

fixes: #259

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: kfox1111 <kfox1111@gmail.com>
@SuperQ
Copy link
Copy Markdown
Member

SuperQ commented Apr 8, 2026

This is interesting, but pulls in gRPC, which pulls in a bunch of dependencies. Not sure about this.

@kfox1111
Copy link
Copy Markdown
Author

kfox1111 commented Apr 8, 2026

@SuperQ what if we put it behind a disable_spiffe build tag? Then those that don't want the dependency can compile it out and those that don't care, gain the extra functionality out of the box?

@SuperQ
Copy link
Copy Markdown
Member

SuperQ commented Apr 8, 2026

The main issue is I think we would want the consistency of having it always available.

@kfox1111
Copy link
Copy Markdown
Author

kfox1111 commented Apr 8, 2026

I would love for it to be always available, as an end user. The ability to flip a switch and security is taken care of is awesome.

kfox1111 added 3 commits April 8, 2026 16:56
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPIFFE support

2 participants