SPIFFE support#387
Open
kfox1111 wants to merge 5 commits into
Open
Conversation
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: kfox1111 <kfox1111@gmail.com>
Member
|
This is interesting, but pulls in gRPC, which pulls in a bunch of dependencies. Not sure about this. |
Author
|
@SuperQ what if we put it behind a disable_spiffe build tag? Then those that don't want the dependency can compile it out and those that don't care, gain the extra functionality out of the box? |
Member
|
The main issue is I think we would want the consistency of having it always available. |
Author
|
I would love for it to be always available, as an end user. The ability to flip a switch and security is taken care of is awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the service to be MTLS secured automatically using SPIFFE/SPIRE.
fixes: #259