fix(om2): make gauge histogram distinguishable from one line#2904
Merged
bwplotka merged 1 commit intokrajo/om2-text-typesfrom Mar 20, 2026
Merged
fix(om2): make gauge histogram distinguishable from one line#2904bwplotka merged 1 commit intokrajo/om2-text-typesfrom
bwplotka merged 1 commit intokrajo/om2-text-typesfrom
Conversation
Change count and sum to `gcount` and `gsum` in the exposition for gauge histograms. This mirrors OM 1.0 suffixes. There's too many complications if we don't do this. The only downside is that the histogram functions in PromQL don't have a gauge version, but I think we can live with that. Or even add those later if anyone needs them - which I doubt. Also fix that gauge histograms model currently doesn't have start timestamp, but our text format seemed to conflict with this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2-gcountgsumunknowncomp
branch
from
997066c to
1a92fbd
Compare
dashpole
approved these changes
Mar 18, 2026
krajorama
added a commit
that referenced
this pull request
Mar 20, 2026
Change count and sum to `gcount` and `gsum` in the exposition for gauge histograms. This mirrors OM 1.0 suffixes. There's too many complications if we don't do this. The only downside is that the histogram functions in PromQL don't have a gauge version, but I think we can live with that. Or even add those later if anyone needs them - which I doubt. Also fix that gauge histograms model currently doesn't have start timestamp, but our text format seemed to conflict with this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
bwplotka
added a commit
that referenced
this pull request
Mar 20, 2026
* fix(om2.0): fixes in type text format The one major fix is that a gauge histogram doesn't have start time. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * fix(om2): make gauge histogram distinguishable from one line (#2904) Change count and sum to `gcount` and `gsum` in the exposition for gauge histograms. This mirrors OM 1.0 suffixes. There's too many complications if we don't do this. The only downside is that the histogram functions in PromQL don't have a gauge version, but I think we can live with that. Or even add those later if anyone needs them - which I doubt. Also fix that gauge histograms model currently doesn't have start timestamp, but our text format seemed to conflict with this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Apply suggestions from code review Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> * make fmt Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change count and sum to
gcountandgsumin the exposition for gauge histograms. This mirrors OM 1.0 suffixes.There's too many complications if we don't do this. The only downside is that the histogram functions in PromQL don't have a gauge version, but I think we can live with that. Or even add those later if anyone needs them - which I doubt.
Also fix that gauge histograms model currently doesn't have start timestamp, but our text format seemed to conflict with this, from #2903 (comment)