Use linear search within unique label validation#887
Open
geekswaroop wants to merge 1 commit intoprometheus:mainfrom
Open
Use linear search within unique label validation#887geekswaroop wants to merge 1 commit intoprometheus:mainfrom
geekswaroop wants to merge 1 commit intoprometheus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roidelapluie @gotjosh
Unique label validation was added in #263
Couple of our prometheus scraper services was spending lots of time on this function, mostly on map rehashing and growth. Profiling revealed that the map used within the unique label validation is contributing to most of this CPU usage.
The duplicate label check in
startLabelNameallocates a newmap[string]struct{}on every call andstartLabelNameis called once per label, not once per metric line. For a metric with N labels, this creates N throwaway maps with resulting inO(N²)map operations per metric line.This PR replaces the map-based check with a linear scan of
currentLabelPairsbefore appending. Since the check runs incrementally on each label addition, two existing labels can never be duplicates because only the new label needs to be compared against previous ones. This preserves the same early-return error behavior.Benchmark
The current test data here has 2-3 labels, and no regression was observed. I added a separate benchmark with 7+ labels (representative of real world metrics emitted) and I see the following.