v0.32.2 rc.0 proposed#5244
Open
ultrotter wants to merge 3 commits into
Open
Conversation
* Fix dispatcher goroutines leak on swap If an alertgroup is marked as destroyed, and we receive a new alert that would go inside it, we now swap it with a new one. When we do that we can't rely on the maintenance job to stop the old group anymore, since it won't be present anymore in the map. So upon a successful "swap" we need to cancel the previous alert group that was in the map, to avoid its goroutine continuing. In addition we also self-cancel inside the alertgroup itself, if we find it is destroyed, so that the goroutine stops running when the first of "doMaintenance", run on destroyed, or swapped out, happens. In addition we fix a more unlikely deletion from the marker in doMaintenance. Signed-off-by: Guido Trotter <guido@hudson-trading.com> * Add a TODO about the DeleteByGroupKey call Signed-off-by: Guido Trotter <guido@hudson-trading.com> --------- Signed-off-by: Guido Trotter <guido@hudson-trading.com> Co-authored-by: Guido Trotter <guido@hudson-trading.com>
Add CHANGELOG entries. Signed-off-by: Guido Trotter <guido@hudson-trading.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Guido Trotter <guido@hudson-trading.com>
siavashs
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please check all the applicable boxes.