docs: clarify weekday range behavior and week start day#5172
Open
vincent067 wants to merge 1 commit into
Open
Conversation
Clarify that Alertmanager follows Go's time.Weekday convention where Sunday = 0 and Saturday = 6. This differs from ISO 8601 where Monday is the first day of the week. Also explain that weekday ranges do not wrap around the week boundary, so saturday:sunday will not match any day and should be written as ['saturday', 'sunday'] instead. Fixes prometheus#3213
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation updated to clarify Alertmanager's weekday numbering scheme, explaining that it uses Go's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TheMeier
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that Alertmanager follows Go's time.Weekday convention where Sunday = 0 and Saturday = 6. This differs from ISO 8601 where Monday is the first day of the week.
Also explain that weekday ranges do not wrap around the week boundary, so
saturday:sundaywill not match any day and should be written as['saturday', 'sunday']instead.Fixes #3213
Summary by CodeRabbit
weekday_rangespecification documentation with clarification on weekday numbering system (Sunday=0, Saturday=6), explanation of non-wrapping range behavior across week boundaries, and practical guidance for configuring day combinations correctly.