feat: Add silence annotation to web UI#5017
Conversation
d1dc089 to
8dc1b82
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for displaying and managing silence annotations in the Alertmanager web UI. Annotations are optional key-value pairs that can be attached to silences for additional context. The implementation adds annotation input fields to the silence creation/edit form and displays annotations in both the silence detail view and silence list view.
Changes:
- Added annotation input field with validation in the silence form
- Added annotation display in silence detail and list views
- Implemented parsing and validation logic for annotation key-value pairs
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/app/src/Views/SilenceView/Views.elm | Displays annotations in the silence detail view with inline matchers styling |
| ui/app/src/Views/SilenceList/SilenceView.elm | Displays annotations in the silence list view and adds "Matchers:" label for consistency |
| ui/app/src/Views/SilenceForm/Views.elm | Adds annotation input UI with add/delete buttons and validation feedback |
| ui/app/src/Views/SilenceForm/Updates.elm | Implements annotation add/delete/update logic and form validation |
| ui/app/src/Views/SilenceForm/Types.elm | Adds annotation data structures, parsing, and validation functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
23de096 to
b44107a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Spaceman1701
left a comment
There was a problem hiding this comment.
Not really a code review of the Elm, but I ran this patch locally and the UI seemed good to me.
It might be nice if the annotations box didn't let you add duplicate annotations, but otherwise it seems fine.
f2d4326 to
7419c99
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7419c99 to
33776ae
Compare
33776ae to
3f396da
Compare
Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
3f396da to
bc03df3
Compare
Pull Request Checklist
Please check all the applicable boxes.
benchstatto compare benchmarksWhich user-facing changes does this PR introduce?