feat(slack): add support for top-level text field in Slack notificati… #4867
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons (prometheus#3071) Signed-off-by: mihir-dixit2k27 <mihidixi@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
7f1af86 to
9669a53
Compare
Signed-off-by: mihir-dixit2k27 <mihidixi@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
9 times, most recently
from
9f1f2ab to
95dc178
Compare
Signed-off-by: mihir-dixit2k27 <mihidixi@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
95dc178 to
92a9b2d
Compare
ultrotter
reviewed
Jan 9, 2026
go.sum
Outdated
| github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8= | ||
| github.com/go-kit/kit v0.8.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as= | ||
| github.com/go-kit/kit v0.9.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as= | ||
| github.com/go-kit/log v0.1.0 h1:DGJh0Sm43HbOeYDNnVZFl8BvcYVvjD5bqYJvp0REbwQ= |
Contributor
There was a problem hiding this comment.
Are these changes to go.mod unrelated?
Contributor
Author
There was a problem hiding this comment.
You are absolutely correct—those changes were unintended updates caused by my local environment. I have reverted go.mod and go.sum to match main, so this PR now remains focused purely on the new feature
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
7512848 to
e3a2f93
Compare
Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
8ed3af5 to
7822d5b
Compare
ultrotter
reviewed
Jan 13, 2026
Contributor
ultrotter
left a comment
ultrotter
left a comment
There was a problem hiding this comment.
Besides the go.mod changes in the diff, LGTM. Can you remove that please?
Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
c9c940c to
d62cd5d
Compare
Contributor
Spaceman1701
left a comment
Spaceman1701
left a comment
There was a problem hiding this comment.
What does the resulting slack message look like when both text and message are set?
Spaceman1701
approved these changes
Jan 20, 2026
Contributor
Spaceman1701
left a comment
Spaceman1701
left a comment
There was a problem hiding this comment.
Thanks for taking the time to make those changes!
Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
c8f932d to
9c485f9
Compare
SuperQ
approved these changes
Jan 21, 2026
Member
|
Files need |
Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
mihir-dixit2k27
force-pushed
the
feat-slack-text-field
branch
from
47e65c0 to
aa62289
Compare
Signed-off-by: mihir-dixit2k27 <143348248+mihir-dixit2k27@users.noreply.github.com>
Contributor
Author
|
@SuperQ ready for re review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3071
Changes:
messagefield toSlackConfig.textfield in the Slack JSON payload.Reasoning:
This allows users to send simple text messages compatible with Slack Workflow Webhooks, which cannot parse attachments.