Update component to make CCM container image configurable #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
simu
force-pushed
the
feat/manage-image-version
branch
from
58621a0 to
f400e6d
Compare
simu
force-pushed
the
feat/manage-image-version
branch
from
f400e6d to
73053b7
Compare
simu
changed the title
Also update manifest fetching to use the image tag by default. We keep the `manifests_version` parameter, but deprecated it and default it to the CCM image tag. Users which set the parameter will get a deprecation warning if they use `manifests_version` with a version that differs from the configured image tag. Additionally, by using the best practices `images` config parameter, we should get automated Renovate version updates for the cloudscale CCM.
simu
force-pushed
the
feat/manage-image-version
branch
from
73053b7 to
212c053
Compare
Member
Author
|
Note that I've explicitly not updated the version to 1.1.1 so we can validate that Renovate works. |
DebakelOrakel
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR also updates manifest fetching to use the image tag by default. We keep the
manifests_versionparameter, but deprecated it and default it to the CCM image tag. Users which set the parameter will get a deprecation warning if they usemanifests_versionwith a version that differs from the configured image tag.Additionally, by using the best practices
imagesconfig parameter, we should get automated Renovate version updates for the cloudscale CCM.Replaces #13
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.