Add support for additional root apps #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/additional-root-apps
branch
5 times, most recently
from
8ef696a to
ceb8974
Compare
Member
Author
|
See projectsyn/documentation#182 for documentation |
4 tasks
simu
force-pushed
the
feat/additional-root-apps
branch
from
ceb8974 to
132498b
Compare
DebakelOrakel
approved these changes
Dec 31, 2024
simu
force-pushed
the
feat/additional-root-apps
branch
from
9b6a436 to
b54103c
Compare
simu
force-pushed
the
feat/additional-root-apps
branch
3 times, most recently
from
7682c1a to
bb8c7a5
Compare
Rendered from template version: main (a8791fb)
We use a small go template to extract the value for `syn_team` from the `project` label of the metric so we can correctly label each individual alert instance. This should allow us to group ArgoCD alerts by `syn_team` (which is already well-defined for alert routing) to ensure that alerts for each AppProject are routed to the responsible team.
Assigning the argocd component to a team other than the cluster owner team doesn't make sense, so we set `_metadata.multi_tenant=false`. Additionally, we update the `.cruft.json` to the latest template hash so future template updates are applied cleanly. Rendered from template version: main (98d16f9)
simu
force-pushed
the
feat/additional-root-apps
branch
from
8df9690 to
482e437
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SDD-0030 - ArgoCD multitenancy for the full design.
TODO
synparameter between this PR and Generate config mapadditional-root-appscomponent-steward#86 and https://github.com/appuio/component-openshift4-monitoring/blob/b7d6534f357a9f72ca2cb676f3e2dc91e37082b9/lib/openshift4-monitoring-prom.libsonnet#L72-L133Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.