Make Python type checking stricter #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
added
the
internal
Enable mypy's `--check-untyped-defs` and disable `--ignore-missing-imports`. The commit also adds a few explicit `type: ignore` for untyped dependencies, and fixes some typing issues surfaced by `--check-untyped-defs`. Requires reclass-rs >= 0.10.0 which provides type stubs.
simu
force-pushed
the
feat/strict-type-checking
branch
from
9f6b219 to
cfb411f
Compare
bastjan
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable mypy's
--check-untyped-defsand disable--ignore-missing-imports.The commit also adds a few explicit
type: ignorefor untyped dependencies, and fixes some typing issues surfaced by--check-untyped-defs.Requires reclass-rs >= 0.10.0 which provides type stubs.
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog