-
Notifications
You must be signed in to change notification settings - Fork 1
SCRUM-260 feature: save user data #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyunjung-choi
wants to merge
8
commits into
develop
Choose a base branch
from
feature/SCRUM-260-save-user-data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
MyPage 상단 설정 버튼에 데이터 초기화 함수를 임시로 적용해놓았습니다 . . ! |
Member
|
이 PR을 먼저 검토하고, #14 는 이 브랜치에서 설정한 Hilt 설정으로 마이그레이션할게요. |
gdaegeun539
requested changes
Jan 21, 2026
Member
gdaegeun539
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거만 먼저 커멘트 부탁드립니다. 나머지 부분은 계속 코드리뷰 진행할게요.
Member
|
기능상으로는 잘 되는듯 보이는데 레이어 상으로 뭔가 애매한듯해서 오늘 퇴근하고 마저 커멘트 남길게요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior if this is a feature change?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
ScreenShots (If needed)