SCRUM-253 feature: onboarding profile info #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdaegeun539
changed the title
Member
|
이거 CI 문제인지 진짜 빌드 안되는건지 있다가 로컬에서 한번 해볼게요 |
Collaborator
Author
|
CI 문제가 아니었슴당 . . . ㅎㅎㅎㅎㅎ |
Member
앗... |
Member
|
가볍게 살펴볼때는 그렇게 특이사항은 없어보이긴 해요 근데 제가 잘못넣은 프로필사진 drawable_xxhdpi 삭제해도 프로필사진을 이번에 갱신한 리소스로 가져오나요? |
Collaborator
Author
네 삭제해도 될 것 같아요. 보니까 똑같은 파일인 것 같아요 ㅎㅎ |
gdaegeun539
approved these changes
Jan 15, 2026
Member
gdaegeun539
left a comment
gdaegeun539
left a comment
There was a problem hiding this comment.
LGTM! 구현 감사합니다! drawable-xxhdpi 에셋만 한번 봐주세요
app/src/main/java/com/lyrics/feelin/core/designsystem/component/FeelinProfileImageSelector.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
온보딩 플로우에서 프로필 설정 화면이 없음
What is the new behavior (if this is a feature change)?
ProfileScreen)FeelinNicknameInputField)ProfileCharacterBottomSheet)ProfileImageSelector)CloseIcon,CameraIcon,CancelIcon,WritingIcon)Does this PR introduce a breaking change?
No
ScreenShots (If needed)