SCRUM-254 design: search input component #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunjung-choi
requested changes
Dec 5, 2025
Collaborator
hyunjung-choi
left a comment
hyunjung-choi
left a comment
There was a problem hiding this comment.
수고하셨습니다 !! 👍👍👍
몇 가지 수정 사항 제안했는데, 확인 부탁드려용
app/src/main/java/com/lyrics/feelin/core/designsystem/component/FeelinSearchInputField.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lyrics/feelin/core/designsystem/component/FeelinSearchInputField.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lyrics/feelin/core/designsystem/component/FeelinSearchInputField.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lyrics/feelin/core/designsystem/component/FeelinSearchInputField.kt
Show resolved
Hide resolved
- make InputClearButton component - use icon instead image to render vector img - add onSearchClick parameter - add options for search field - lineLimits - keyboardOptions(imeAction, keyboard type) - onKeyboardAction - maxLength
Member
Author
|
말씀주신 사항들 수정했습니다! 한번 다시 확인 부탁드려요 |
- remove unnecessary InputClearButton
- FeelinSearchInputField - InnerTextFieldComponent
Member
Author
|
확인해주셔서 감사합니다! 새로 컴포넌트로 묶은 부분도 큰 문제 없으면 머지하겠습니다. |
Collaborator
|
오 ! 좋아요 !! 바로 머지합시당 |
Member
Author
감사합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
SCRUM-254
곡 추가, 아티스트 검색 등에서 사용하는 검색창 컴포넌트가 없는 상황입니다.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes.
ScreenShots (If needed)
Other information: