fix(plugin install): copy executable by renaming instead of create file

commands/pluginhelper.go

@@ -105,7 +105,7 @@ func UpdateCLI(pluginPkg string, updateOption int) error {
 		cliExe = cliExe + ".exe"
 	}
 
-	err = util.Copy(filepath.Join(cliCmdPath, cliExe), exPath, false)
+	err = util.SwapFile(filepath.Join(cliCmdPath, cliExe), exPath)
 	if err != nil {
 		//fmt.Fprintf(os.Stderr, "Error: %v\n", osErr)
 		return err

util/file.go

@@ -171,4 +171,34 @@ func DeleteFile(path string) error {
 	}
 
 	return nil
-}
+}
+
+// SwapFile is like a copy but use a temporary file and rename it
+// to allow running executable replacement.
+// Thanks to https://gist.github.com/fenollp/7e31e6462b10c96aef443351bce6aea7
+func SwapFile(src, dst string) error {
+	srcInfo, err := os.Stat(src)
+	if err != nil {
+		return err
+	}
+	destDir := filepath.Dir(dst)
+	tmpFile := filepath.Join(destDir, "exe_swap")
+
+	defer DeleteFile(tmpFile)
+
+	data, err := ioutil.ReadFile(src)
+	if err != nil {
+		return err
+	}
+
+	if err := ioutil.WriteFile(tmpFile, data, srcInfo.Mode()); err != nil {
+		return err
+	}
+
+	if err := os.Rename(tmpFile, dst); err != nil {
+		return err
+	}
+
+	return nil
+
+}