Skip to content

conf: ai scaffolding tier1#1094

Merged
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-61336
May 26, 2026
Merged

conf: ai scaffolding tier1#1094
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-61336

Conversation

@pawelpaszki
Copy link
Copy Markdown
Contributor

@pawelpaszki pawelpaszki commented May 20, 2026

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-61475

What changes have been made

RHOAIENG-61475: ai scaffolding tier1

Added ruff linter and formatter to the codeflare-sdk project with configuration in pyproject.toml,
pre-commit hooks, and a new CI workflow (.github/workflows/lint.yml) that enforces code quality on every commit and PR. 
Import sorting was intentionally disabled to avoid circular import issues, while pyflakes and pycodestyle rules were enabled with pragmatic ignores for existing codebase patterns, auto-fixing 71 lint errors and reformatting 32 files.

Verification steps

Sanity check the changes - they conform to the specification from here (tier 1 only for now)

the changes were verified by running pre-commit with new checks and then by running e2e tests from an image built from this branch against an OpenShift cluster with RHOAI 3.4 installed

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests (e2e on Openshift)
    • Testing is not required for this change

@openshift-ci openshift-ci Bot requested review from kryanbeane and szaher May 20, 2026 08:32
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.62%. Comparing base (f6bd897) to head (db3995a).

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/cluster/build_ray_cluster.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   96.62%   96.62%   -0.01%     
==========================================
  Files          23       23              
  Lines        2314     2309       -5     
==========================================
- Hits         2236     2231       -5     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pawelpaszki pawelpaszki added test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks test-additional-notebooks labels May 20, 2026
Copy link
Copy Markdown
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 25, 2026
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c01f535 into project-codeflare:main May 26, 2026
21 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-61336 branch May 26, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-additional-notebooks test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants