Standardize notebook intro text and clean up import cells#1060
Standardize notebook intro text and clean up import cells#1060laurafitzgerald wants to merge 2 commits into
Conversation
- Add 'First, we'll need to import...' text to all notebooks missing it - Remove '# Import pieces from codeflare-sdk' and '# Imports' comments - Remove stray leading blank lines from import cells - Update 5_submit_rayjob_cr auth cell from oc login to kube-authkit
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 23 23
Lines 2271 2271
=======================================
Hits 2192 2192
Misses 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes end-of-file-fixer pre-commit hook failures on 9 notebooks that were missing a trailing newline after the closing brace.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue link
TBD
What changes have been made
Standardize notebook intro text and clean up import cells
Verification steps
Upload the notebooks and verify that the imports and logins are consistent and that for notebooks where auth updates are
Checks