Skip to content

Standardize notebook intro text and clean up import cells#1060

Open
laurafitzgerald wants to merge 2 commits into
project-codeflare:mainfrom
laurafitzgerald:notebook-auth-cleanup-consistency
Open

Standardize notebook intro text and clean up import cells#1060
laurafitzgerald wants to merge 2 commits into
project-codeflare:mainfrom
laurafitzgerald:notebook-auth-cleanup-consistency

Conversation

@laurafitzgerald
Copy link
Copy Markdown
Contributor

  • Add 'First, we'll need to import...' text to all notebooks missing it
  • Remove '# Import pieces from codeflare-sdk' and '# Imports' comments
  • Remove stray leading blank lines from import cells
  • Update 5_submit_rayjob_cr auth cell from oc login to kube-authkit

Issue link

TBD

What changes have been made

Standardize notebook intro text and clean up import cells

  • Add 'First, we'll need to import...' text to all notebooks missing it
  • Remove '# Import pieces from codeflare-sdk' and '# Imports' comments
  • Remove stray leading blank lines from import cells
  • Update 5_submit_rayjob_cr auth cell from oc login to kube-authkit

Verification steps

Upload the notebooks and verify that the imports and logins are consistent and that for notebooks where auth updates are

  • demo-notebooks/guided-demos/5_submit_rayjob_cr.ipynb
  • demo-notebooks/guided-demos/4_rayjob_existing_cluster.ipynb

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

- Add 'First, we'll need to import...' text to all notebooks missing it
- Remove '# Import pieces from codeflare-sdk' and '# Imports' comments
- Remove stray leading blank lines from import cells
- Update 5_submit_rayjob_cr auth cell from oc login to kube-authkit
@openshift-ci openshift-ci Bot requested a review from dimakis April 21, 2026 08:59
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from kryanbeane April 21, 2026 08:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.52%. Comparing base (8ddddf7) to head (55a1e05).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          23       23           
  Lines        2271     2271           
=======================================
  Hits         2192     2192           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak chipspeak self-requested a review April 21, 2026 10:12
Fixes end-of-file-fixer pre-commit hook failures on 9 notebooks that
were missing a trailing newline after the closing brace.
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant