Skip to content

Fix GCC 13+ optimization bug in BMW256 for LYRA2REv2 hashing #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melvincarvalho wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix GCC 13+ optimization bug in BMW256 for LYRA2REv2 hashing #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151b87b
Fix GCC 13+ optimization bug in BMW256 for LYRA2REv2 hashing
melvincarvalho Jan 9, 2026
880294e
Address Copilot review feedback
melvincarvalho Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,24 @@ include Makefile.include

AM_CPPFLAGS += -I$(builddir)

# GCC 13+ has optimization bugs that affect the BMW256 hash function used in LYRA2RE.
# These files must be compiled with reduced optimization (-O1) to work around a GCC 13+
# optimizer bug that produces incorrect code at higher optimization levels.
# See: https://github.com/project-bitmark/bitmark/issues/141
LYRA2RE_CFLAGS = -O1

bmw.o: bmw.c
$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(LYRA2RE_CFLAGS) -c -o $@ $<

Lyra2RE.o: Lyra2RE.c
$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(LYRA2RE_CFLAGS) -c -o $@ $<

Lyra2.o: Lyra2.c
$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(LYRA2RE_CFLAGS) -c -o $@ $<

Sponge.o: Sponge.c
$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(LYRA2RE_CFLAGS) -c -o $@ $<

noinst_LIBRARIES = \
libbitmark_server.a \
libbitmark_common.a \
Expand Down