Improved product menu navigation on the homepage #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Alle de checkene som feiler er min feil. Skal fikse de i main, sånn at det blir fikset her. |
Member
|
Da er det bare et bare et par "feil" igjen fra linting. Du ser de ved å kjøre |
…ammer.bar into change-meny-page-nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the product menu navigation on the homepage to make it easier to use on mobile.
When the user navigates manually, the time before switching to the next slide is doubled.
Added aria-hidden="true" because automatic slide transitions make the menu confusing and difficult to use for screen reader users. In this case, it is better for them to navigate directly to the menu page instead.