Skip to content

fix path traversal vulnerability in config loader #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
May 13, 2026
Merged

fix path traversal vulnerability in config loader #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions node/crates/c0mpute-core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,30 @@ impl Config {
if !path.exists() {
return Ok(Self::default());
}
let text = std::fs::read_to_string(path)
.with_context(|| format!("read config {}", path.display()))?;

// Canonicalize path to resolve symlinks and ".." components, preventing
// path traversal attacks.
let canonical = path
.canonicalize()
.with_context(|| format!("canonicalize config path {}", path.display()))?;

// Validate the canonical path is within the expected config directory.
if let Some(cfg_dir) = config_dir() {
if let Ok(canonical_cfg_dir) = cfg_dir.canonicalize() {
if !canonical.starts_with(&canonical_cfg_dir) {
anyhow::bail!(
"config path {} is outside allowed directory {}",
canonical.display(),
canonical_cfg_dir.display()
);
}
}
}

let text = std::fs::read_to_string(&canonical)
.with_context(|| format!("read config {}", canonical.display()))?;
let cfg: Config = toml::from_str(&text)
.with_context(|| format!("parse config {}", path.display()))?;
.with_context(|| format!("parse config {}", canonical.display()))?;
Ok(cfg)
}

Expand Down
Loading