profanity: exit gracefully on SIGTERM and SIGHUP #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry for the long time to wait and thank you for your PR. I guess this is useful to cleanup properly, update our presence (do we even do that?) and close the connection properly. I would appreciate if you could expand the commit message a bit. For example adding to the commit body why you do this, the purpose. While at it you can also remove the |
Make profanity exit gracefully when it receives either SIGTERM or SIGHUP. This means that various cleanups will happen as if the user issued the /quit command, whereas before these signals would terminate profanity immediately leaving for instance the connection to the server unterminated. The main motivation for this change is so that profanity will exit gracefully when the user closes the terminal that it's running in, which is a handy shortcut (but can also happen on accident) and won't now lead to the connection slowly timing out on the server instead. Similarly for SIGTERM: profanity now for instance needs not be manually closed before shutting down the computer to avoid the above as it will instead receive this signal from the init process.
Contributor
Author
|
Thank you for your feedback! I have updated the commit message as
requested, please let me know if anything else needs changing.
|
jubalh
approved these changes
Jan 22, 2026
Member
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the functionality
Launch profanity and connect to server. Verify it can be seen as connected by other clients.
Send SIGTERM to it or close the terminal it's running in. Verify in the other clients that it immediately comes offline, rather than only after a while when the connection times out.