⬆️ Use fetch instead of axios (second attempt)

[rdubigny]

Problem

We want to remove axios to reduce the number of dependencies, which will also reduce the attack surface. We also want to standardize our practices by using fetch everywhere.

During the first attempt, we encountered an error in the production Internet environment with the IdP FIDGFiP-RIE.

Here are the details of the error:

"type": "OidcClientTokenFailedException",
"method": "GET",
"path": "/api/v2/oidc-callback",
"idpLabel": "Agents de la DGFiP (Réseau Interministériel de l'État)",
"code": "Y020026",
"causes": [
  {
    "type": "ClientError",
    "message": "parsing error occured",
    "stack": [
      "ClientError: parsing error occured",
      "    at e (file:///var/www/app/node_modules/openid-client/build/index.js:116:12)",
      "    at errorHandler (file:///var/www/app/node_modules/openid-client/build/index.js:137:23)",
      "    at authorizationCodeGrant (file:///var/www/app/node_modules/openid-client/build/index.js:991:9)",
      "    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)",
      "    at async OidcClientService.getToken (/var/www/app/dist/instances/app/main.js:8291:22)",
      "    at async OidcClientController.getOidcCallback (/var/www/app/dist/instances/app/main.js:14396:50)"
    ]
  },
  {
    "message": "failed to parse \"response\" body as JSON",
    "stack": [
      "OperationProcessingError: failed to parse \"response\" body as JSON",
      "    at OPE (file:///var/www/app/node_modules/oauth4webapi/build/index.js:116:12)",
      "    at getResponseJsonBody (file:///var/www/app/node_modules/oauth4webapi/build/index.js:2496:15)",
      "    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)",
      "    at async processGenericAccessTokenResponse (file:///var/www/app/node_modules/oauth4webapi/build/index.js:1216:18)",
      "    at async processAuthorizationCodeOpenIDResponse (file:///var/www/app/node_modules/oauth4webapi/build/index.js:1417:20)",
      "    at async authorizationCodeGrant (file:///var/www/app/node_modules/openid-client/build/index.js:980:18)",
      "    at async OidcClientService.getToken (/var/www/app/dist/instances/app/main.js:8291:22)",
      "    at async OidcClientController.getOidcCallback (/var/www/app/dist/instances/app/main.js:14396:50)"
    ],
    "type": "OperationProcessingError"
  },
  {
    "message": "terminated",
    "stack": [
      "TypeError: terminated",
      "    at Fetch.onAborted (node:internal/deps/undici/undici:12707:53)",
      "    at Fetch.emit (node:events:508:28)",
      "    at Fetch.terminate (node:internal/deps/undici/undici:11866:14)",
      "    at Object.onError (node:internal/deps/undici/undici:12831:38)",
      "    at Gunzip.emit (node:events:520:35)",
      "    at emitErrorNT (node:internal/streams/destroy:170:8)",
      "    at emitErrorCloseNT (node:internal/streams/destroy:129:3)",
      "    at process.processTicksAndRejections (node:internal/process/task_queues:89:21)"
    ],
    "type": "TypeError"
  },
  {
    "message": "incorrect header check",
    "stack": [
      "Error: incorrect header check",
      "    at genericNodeError (node:internal/errors:985:15)",
      "    at wrappedFn (node:internal/errors:539:14)",
      "    at Zlib.zlibOnError [as onerror] (node:zlib:190:17)"
    ],
    "type": "Error"
  }
],
"message": "parsing error occured",
"idpLoginHintFqdn": "dgfip.finances.gouv.fr",
"levelNumber": 50,
"originalError": {
  "name": "ClientError",
  "code": "OAUTH_PARSE_ERROR"
},
"statusCode": 400,
"idpName": "FIDGFiP-RIE",
"stackTrace": [
  "ClientError: parsing error occured",
  "    at e (file:///var/www/app/node_modules/openid-client/build/index.js:116:12)",
  "    at errorHandler (file:///var/www/app/node_modules/openid-client/build/index.js:137:23)",
  "    at authorizationCodeGrant (file:///var/www/app/node_modules/openid-client/build/index.js:991:9)",
  "    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)",
  "    at async OidcClientService.getToken (/var/www/app/dist/instances/app/main.js:8291:22)",
  "    at async OidcClientController.getOidcCallback (/var/www/app/dist/instances/app/main.js:14396:50)",
  "Error: parsing error occured",
  "    at OidcClientService.getToken (/var/www/app/dist/instances/app/main.js:8313:19)",
  "    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)",
  "    at async OidcClientController.getOidcCallback (/var/www/app/dist/instances/app/main.js:14396:50)"
],
"level": "error",
"id": "a47bab91-5c43-47ab-a620-f44b867287cc",

Proposal

Replace axios with fetch.

Deploy the hyyyperbridge consumer to the production environment on nubo01,
without merging it to main, to observe how it behaves with the FIDGFiP-RIE
IdP.

[rdubigny]

Ne plus utiliser Axios dans le consumer RIE

[rdubigny]

Note:

Issue nodejs/undici#4774 has been fixed by nodejs/undici#4775 and landed in Undici 7.24.6. This version will land in Node.js v24.16 via nodejs/node#63263 around mid-May.

[douglasduteil]

LGTM

[rdubigny]

We deployed this PR for one hour and did not see any specific error with the FIDGFiP-RIE IdP.