has been added optional parameter MaxPacketSize#1
Open
dscherbak wants to merge 5 commits intoprocessone:masterfrom
Open
has been added optional parameter MaxPacketSize#1dscherbak wants to merge 5 commits intoprocessone:masterfrom
dscherbak wants to merge 5 commits intoprocessone:masterfrom
Conversation
added 2 commits
July 8, 2016 14:10
Signed-off-by: Dmitriy Scherbak <dmitiy_scherbak@dbbest.com>
mremond
reviewed
Jan 17, 2019
| %% Returns : result of p1_mysql_conn:do_recv/3 | ||
| %%-------------------------------------------------------------------- | ||
| do_new_auth(Sock, RecvPid, SeqNum, User, Password, Salt1, Salt2, LogFun) -> | ||
| do_new_auth(Sock, RecvPid, SeqNum, User, Password, Salt1, Salt2, undefinded, LogFun) |
Member
There was a problem hiding this comment.
That undefinded value here is suspicious.
Author
There was a problem hiding this comment.
Is it still hardcoded value MaxPacketSize (~1mb)?
Collaborator
|
Hi @dscherbak, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
p1bot
added
the
cla-missing
Collaborator
|
You did it @dscherbak! Thank you for signing the ProcessOne Contribution License Agreement. We will have a look at your contribution! |
p1bot
removed
the
cla-missing
|
@prefiks: Can you look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use MaxPacketSize optional parameter instead of using hard coded value.