Add missing Korean UI translations #1267
Open
star11293 wants to merge 2 commits intoprocessing:mainfrom
Open
Conversation
Member
|
Hi @hana-cho, if you have a bit of time, would you be able to review this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1207
I looked into why the korean "Jump to" menu was showing chinese and found that ko.yaml was only translating 6 out of 17 referenceCategories modules. The rest were missing entirely so the site was falling back to wrong text.
I added all the missing module and submodule entries plus some other keys that zh-Hans and en had but ko didn't (exampleCategories, libraryCategories, callout titles etc).
Just a quick heads up i don't speak korean so I cross referenced the chinese simplified file and looked up standard computing terms in Korean. Would appreciate a native speaker reviewing before this gets merged.