Basic case insensitive route matching#1260
Merged
ksen0 merged 3 commits intoprocessing:2.0from Mar 20, 2026
Merged
Conversation
ksen0
approved these changes
Mar 20, 2026
Member
|
@limzykenneth it's live, but https://beta.p5js.org/reference/p5/strokemode/ still 404s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses case insensitive route matching on the reference pages so that
https://beta.p5js.org/reference/p5/frameCount/andhttps://beta.p5js.org/reference/p5/framecount/both show the same content. There are some limitations to this approach./reference/will need to either have the correct case or be fully lower case. eg./p5.Vector/magSq/and/p5.vector/magsq/will match but/p5.vector/magSq/and/p5.Vector/magsq/will not match.The reason for the limitations are because Astro is currently rendering all content as static pages, meaning to match something case insensitively, it will need to generate relevant folders and HTML files for case sensitive and case insensitive cases.
/p5.Vector/magSq/and/p5.vector/magsq/are matching two different files with the same content.To achieve full case insensitive routing, SSR will need to be used as only the server will be able to determine case insensitively what the route is trying to match. We can do this after #1243 is merged but will need some consideration on whether to do SSR or not.