Fix hydration flash in global sidebar nav #1102
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the hydration mismatch in the global
NavPanelscomponent that caused the sidebar to visually "flash" on reload, especially on desktop.The fix lazily initializes
isMobileandisOpenstate fromwindow.innerWidthinstead of mutating layout state inuseEffect, ensuring the server-rendered HTML matches the first client render.What Changed
isMobileandisOpenusing a lazyuseStateinitializerResizeObserverwith a simplewindow.resizelistener for breakpoint changesBehavior Notes (Mobile)
To keep this fix scoped to the original issue, SSR still assumes a desktop layout to prevent the desktop hydration flash.
On mobile hard reloads, this can cause a brief state resync (no visible flash), where the first toggle click may synchronize state before closing.
If desired, I can follow up with a mobile-specific PR using a CSS or
client:media-based approach.Testing
Related Issue
Closes #477