Skip to content

Conversation

@Nitish-bot
Copy link
Contributor

Closes #57

@Nitish-bot
Copy link
Contributor Author

have also tried to implement a translate_3d and sphere function that appends a sphere to the current geoemetry mesh but Im not sure if it's a particularly correct implementation. It currently throws an error that goes: GeometryNotFound

Upon running the example without the sphere function, it displays nothing but also doesn't throw an error which makes me think all is going well.

@catilac catilac self-requested a review January 24, 2026 18:52
@catilac
Copy link
Contributor

catilac commented Jan 25, 2026

Hi @Nitish-bot, thank you again for working on this. I'm finally running your patch. It isn't working, and the PR has gone beyond scope, and we are limited on time for debugging folks' work.

If you would like, remove the sphere implementation, and the translate related code you added as well as it's out of scope and broken. Then make an implementation that demonstrates the begin/end_geometry implementation is actually working, using the other functionality that does work (ie draw_cube).

Lastly, take a screenshot before you re-open this PR demonstrating that it is working.

We are still in the design phase for a lot of the API and much of it will change and we aren't ready to support new contributors for most tasks. We are trying to get there! And I really want you to be involved, but this not a stable enough project to quickly bring people into just yet.

@catilac catilac closed this Jan 25, 2026
@catilac catilac reopened this Jan 26, 2026
@catilac catilac requested a review from tychedelia January 26, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pyo3] Create beginGeometry/endGeometry methods in python

2 participants