Skip to content

Confirmation for Overwrite#858

Draft
probonopd wants to merge 1 commit intomainfrom
probonopd-overwrite
Draft

Confirmation for Overwrite#858
probonopd wants to merge 1 commit intomainfrom
probonopd-overwrite

Conversation

@probonopd
Copy link
Copy Markdown
Owner

@probonopd probonopd commented Apr 20, 2025

Like for Delete; closes #856

@github-actions
Copy link
Copy Markdown

Build for testing:
MiniDexed_2025-04-20-51bdf3d
Use at your own risk.

@soyersoyer
Copy link
Copy Markdown
Contributor

For consistency, could bOverwriteMode and bConfirmOverwrite be private members?

@probonopd
Copy link
Copy Markdown
Owner Author

Great point @soyersoyer. It should. Will change it once it is confirmed that functionality-wise this fulfills the requestor's requirement.

Hello @Octet-nl, would you like to test the build above? Thanks.

@Banana71
Copy link
Copy Markdown

It doesn't work.

I can save a new performance. It automatically uses the next available slot for the new performance.
Overwriting doesn't work. Save - Overwrite - "Overwrite? the performance name is in the second line" after clicking to confirm, the UI crashes. The sound still works, but the controls freeze.
No changes to the performance are saved either.
Peter

@probonopd
Copy link
Copy Markdown
Owner Author

Argh. Will need to dig deeper. Thanks for testing though (currently away from my hardware).

@Octet-nl
Copy link
Copy Markdown

Same for me. Back button still works and UI stays active. Voice functions still work, sound ok. Selecting Overwrite no longer works (does not show Overwrite? again). Performance is not saved.

@probonopd probonopd marked this pull request as draft April 21, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show name when saving performance

4 participants