Pin tfp-nightly to prevent recurrence of #428 and fix #443#444
Open
retconrecon wants to merge 2 commits intoprobml:mainfrom
Open
Pin tfp-nightly to prevent recurrence of #428 and fix #443#444retconrecon wants to merge 2 commits intoprobml:mainfrom
retconrecon wants to merge 2 commits intoprobml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
Fixes #443
Pins
tfp-nightlyto==0.26.0.dev20260101instead of leaving it unpinned.Why: Nightly builds aren't QA-gated, so an unpinned
tfp-nightlycould resolve to a different build on any given day — the exposure window to breaking changes is daily rather than per-stable-release. Pinning to a verified build preserves reproducibility and reduces the risk of a similar breakage recurring from an upstream change.Verified against:
When TFP ships a stable release with JAX 0.7+ support, this can be reverted back to
tensorflow_probability.