chore: expand support for custom trees by francinelucca · Pull Request #7817 · primer/react

francinelucca · 2026-05-07T19:01:11Z

Inspect the requested review comment and related code path
Run baseline validation commands before changes
Apply the minimal code change for comment r3211420664 only
Run targeted tests for TreeView roving tab index behavior
Reply to the review comment with the addressing commit hash
Run final parallel validation before completion

…eeitem' and 'tree'

changeset-bot · 2026-05-07T19:01:19Z

🦋 Changeset detected

Latest commit: de4b18a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-05-07T19:02:01Z

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

…ct into chore/expand-actionlist-roles

primer-integration · 2026-05-08T18:37:02Z

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/20288

primer-integration · 2026-05-08T20:45:05Z

Integration test results from github/github-ui:

CI Passed
VRT Passed
Projects Passed

All checks passed!

joshblack

Could we add tests/stories for the new functionality?

…onlist-roles

Copilot

Pull request overview

This PR expands support for tree-like structures by broadening ActionList’s supported ARIA roles and by making TreeView’s roving-tabindex behavior reusable via a new public useRovingTabIndex export.

Changes:

Expanded ActionList.Item role handling to include treeitem and tree.
Enhanced useRovingTabIndex with opt-in configuration (e.g. wrap-around, preventScroll, focus-out behavior) and exported it from the package entrypoint.
Exposed ActionListContainerContext via ActionList.ContainerContext and added a changeset for a minor release.

Show a summary per file

File	Description
packages/react/src/TreeView/useRovingTabIndex.ts	Extends roving tabindex logic with new options (wrap-around, focus-out behavior, preventScroll) and improved element resolution.
packages/react/src/index.ts	Re-exports `useRovingTabIndex` from the public API.
packages/react/src/ActionList/Item.tsx	Expands selectable/list role allowlists to include `treeitem`/`tree`.
packages/react/src/ActionList/index.ts	Adds `ActionList.ContainerContext` static for advanced composition use cases.
packages/react/src/tests/snapshots/exports.test.ts.snap	Updates export snapshot to include `useRovingTabIndex`.
.changeset/expand-actionlist-roles.md	Declares a minor bump and describes the new exports/role support.

Copilot's findings

Files reviewed: 6/6 changed files
Comments generated: 3

Copilot · 2026-05-08T21:52:22Z

+export function useRovingTabIndex(
+  {
    containerRef,
-    bindKeys:
-      FocusKeys.ArrowVertical |
-      FocusKeys.ArrowHorizontal |
-      FocusKeys.HomeAndEnd |
-      FocusKeys.Backspace |
-      FocusKeys.PageUpDown,
-    preventScroll: true,
-    getNextFocusable: (direction, from, event) => {
-      if (!(from instanceof HTMLElement)) return
-
-      // Skip elements within a modal dialog
-      // This need to be in a try/catch to avoid errors in
-      // non-supported browsers
-      try {
-        if (from.closest('dialog:modal')) {
-          return
+    mouseDownRef,
+    focusOutBehavior,
+    preventScroll = true,
+    wrapAround = false,
+  }: {
+    containerRef: React.RefObject<HTMLElement | null>
+    mouseDownRef?: React.RefObject<boolean>
+    preventScroll?: boolean
+    focusOutBehavior?: 'stop' | 'wrap'
+    wrapAround?: boolean
+  },
+  dependencies: React.DependencyList = [],
+) {


Updated in 5ba0289. I changed useRovingTabIndex to pass [preventScroll, focusOutBehavior, wrapAround, ...dependencies] into useFocusZone, so those options now re-initialize the focus zone when they change while still allowing additional caller-provided dependencies.

…ct into chore/expand-actionlist-roles

francinelucca · 2026-05-08T21:33:41Z

@joshblack added tests in ActionList that test the selection part when role="tree", and added a test file to useRovingTabIndex with general tests as well as the new opt-in features. I don't think it's worth the effort // we get much value out of creating stories for "ActionList as tree" here. Can definitely add if you feel otherwise!

joshblack · 2026-05-08T21:36:27Z

@francinelucca my thought is that functionality that folks can use should be documented in storybook so that they can discover it either in storybook or through the docs site. Let me know what you think 👀

primer · 2026-05-08T21:41:05Z

🤖 Lint issues have been automatically fixed and committed to this PR.

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

…ct into chore/expand-actionlist-roles

chore: expand selectableRoles and listRoleTypes arrays to include 'tr…

046e7d4

…eeitem' and 'tree'

francinelucca changed the title ~~chore: expand selectableRoles and listRoleTypes arrays to include 'tr…~~ chore: expand selectableRoles and listRoleTypes arrays to include 'treeitem' and 'tree' May 7, 2026

francinelucca added the Canary Release Apply this label when you want CI to create a canary release of the current PR label May 7, 2026

github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 7, 2026

francinelucca deployed to github-pages May 7, 2026 19:11 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 7, 2026 19:11 Inactive

chore: add ActionListContainerContext to ActionList export

5f38b59

francinelucca deployed to github-pages May 7, 2026 20:20 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 7, 2026 20:21 Inactive

add config items to useRovingTabIndex and export through public API

90c5e10

francinelucca deployed to github-pages May 7, 2026 23:18 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 7, 2026 23:18 Inactive

francinelucca and others added 2 commits May 7, 2026 19:26

use preventScroll config

f52488c

Merge branch 'main' into chore/expand-actionlist-roles

f35949d

github-actions Bot requested a deployment to storybook-preview-7817 May 7, 2026 23:35 Abandoned

francinelucca deployed to github-pages May 7, 2026 23:45 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 7, 2026 23:45 Inactive

francinelucca changed the title ~~chore: expand selectableRoles and listRoleTypes arrays to include 'treeitem' and 'tree'~~ chore: expand support for custom trees May 8, 2026

francinelucca added 3 commits May 8, 2026 14:21

add changeset

6cb12d0

Merge branch 'chore/expand-actionlist-roles' of github.com:primer/rea…

ef4d678

…ct into chore/expand-actionlist-roles

fix changeset

17fa9db

github-actions Bot requested a deployment to storybook-preview-7817 May 8, 2026 18:26 Abandoned

francinelucca deployed to github-pages May 8, 2026 18:34 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 8, 2026 18:34 Inactive

francinelucca marked this pull request as ready for review May 8, 2026 20:31

francinelucca requested a review from a team as a code owner May 8, 2026 20:31

francinelucca requested review from Copilot and jonrohan and removed request for Copilot May 8, 2026 20:31

joshblack reviewed May 8, 2026

View reviewed changes

francinelucca and others added 2 commits May 8, 2026 16:59

Merge branch 'main' of github.com:primer/react into chore/expand-acti…

3a7bd97

…onlist-roles

Merge branch 'main' into chore/expand-actionlist-roles

4faf9c9

Copilot AI review requested due to automatic review settings May 8, 2026 21:15

Copilot started reviewing on behalf of francinelucca May 8, 2026 21:16 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

francinelucca deployed to github-pages May 8, 2026 21:26 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 8, 2026 21:27 Inactive

francinelucca added 2 commits May 8, 2026 17:33

add tests

c32696a

Merge branch 'chore/expand-actionlist-roles' of github.com:primer/rea…

b7fd9f8

…ct into chore/expand-actionlist-roles

francinelucca requested a review from joshblack May 8, 2026 21:33

francinelucca deployed to github-pages May 8, 2026 21:44 — with GitHub Actions View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 8, 2026 21:44 Inactive

Copilot started work on behalf of francinelucca May 8, 2026 21:47 View session

Make useRovingTabIndex reactive to option changes

5ba0289

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

Copilot finished work on behalf of francinelucca May 8, 2026 21:54

Copilot AI deployed to github-pages May 8, 2026 22:04 View deployment

github-actions Bot temporarily deployed to storybook-preview-7817 May 8, 2026 22:04 Inactive

francinelucca added 2 commits May 8, 2026 18:50

ignore new test file for implementsClassName

498980b

Merge branch 'chore/expand-actionlist-roles' of github.com:primer/rea…

de4b18a

…ct into chore/expand-actionlist-roles

francinelucca deployed to github-pages May 8, 2026 23:00 — with GitHub Actions View deployment

github-actions Bot deployed to storybook-preview-7817 May 8, 2026 23:00 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: expand support for custom trees#7817

chore: expand support for custom trees#7817
francinelucca wants to merge 15 commits intomainfrom
chore/expand-actionlist-roles

francinelucca commented May 7, 2026 •

edited by Copilot AI

Loading

Uh oh!

changeset-bot Bot commented May 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

primer-integration Bot commented May 8, 2026

Uh oh!

primer-integration Bot commented May 8, 2026

Uh oh!

joshblack left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI May 8, 2026

Uh oh!

Uh oh!

francinelucca commented May 8, 2026

Uh oh!

joshblack commented May 8, 2026

Uh oh!

primer Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

francinelucca commented May 7, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented May 7, 2026

⚠️ Action required

Uh oh!

primer-integration Bot commented May 8, 2026

Uh oh!

primer-integration Bot commented May 8, 2026

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Copilot AI May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francinelucca commented May 8, 2026

Uh oh!

joshblack commented May 8, 2026

Uh oh!

primer Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francinelucca commented May 7, 2026 •

edited by Copilot AI

Loading

changeset-bot Bot commented May 7, 2026 •

edited

Loading